Use BaseTask
java home in jpackage tasks
#143
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the java home in
JPackageData
and uses instead the one defined inBaseTask
.This is to fix an issue where specifying a different java home in the configuration doesn't apply to the jpackage task.
I tested it by using this branch and running the task
test:packageWinX64
on Windows (which will run the jpackage task)This requires to have a setup like the following:
Checking out the
master
branch of the runtime plugin fails the build (as it tries to use the gradle jdk - 11, to run jpackage, which doesn't exist), while the fix branch succeeds