Skip to content

Commit

Permalink
Add tini to the user images
Browse files Browse the repository at this point in the history
RStudio daemonizes itself when it starts, so it isn't being
passed the SIGTERM when the user pod stops. So it exits
uncleanly, causing corruption and other state issues. tini should
properly reap the rstudio processes during exit.

Ref berkeley-dsep-infra/datahub#2878
Ref berkeley-dsep-infra/datahub#2891
  • Loading branch information
yuvipanda committed Oct 19, 2021
1 parent 2966ff7 commit 68d2650
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ RUN apt-get update -qq --yes && \
tmux \
wget \
vim \
tini \
build-essential \
locales > /dev/null

Expand Down Expand Up @@ -62,3 +63,5 @@ RUN JUPYTER_DATA_DIR=${CONDA_DIR}/share/jupyter julia -e 'using Pkg; Pkg.add("IJ

COPY install-julia-packages.jl /tmp/install-julia-packages.jl
RUN /tmp/install-julia-packages.jl

ENTRYPOINT ["/tini", "--"]

0 comments on commit 68d2650

Please sign in to comment.