Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding shared directory to Econ 148 based on bcourses group affiliation #5488

Merged
merged 4 commits into from
Feb 3, 2024
Merged

Adding shared directory to Econ 148 based on bcourses group affiliation #5488

merged 4 commits into from
Feb 3, 2024

Conversation

balajialg
Copy link
Contributor

@balajialg balajialg commented Feb 1, 2024

Just testing the functionality to have a shared/shread read write directories for a group based on bcourses affiliation.

@ericvd-ucb gave his approval to use Econ 148 as a guinea pig for this functionality.

Reviewed the documentation here to make this change

bcourses group for reference,

image

Copy link
Collaborator

@ryanlovett ryanlovett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it might need extraVolumeMounts as the dictionary key. (which the docs erroneously omit) For example:

    course::1532866::group::shared_readwrite:
      extraVolumeMounts:
        - name: home
          mountPath: /home/jovyan/shared-readwrite
          subPath: _shared

Note that I've omitted readOnly: true since the comment says "shared_readwrite". I've also added -readwrite to the mount path. Our convention in datahub is to use shared for shared read-only directories and shared-readwrite for shared read-write directories.

You will also need to create the directory _shared in the filestore, along side the user home directories.

@balajialg
Copy link
Contributor Author

balajialg commented Feb 1, 2024

Thanks a ton, @ryanlovett! I replicated your suggestions in the config file. I might need some help with creating "_shared"directory in filestore. I will reach out via Slack!

@balajialg
Copy link
Contributor Author

@ryanlovett @shaneknapp How do I create a shared dir for this course in filestore? Is there any documentation that I can take a look at?

I logged into NFS server; Trying to find the location where homedirs are mounted.

@ryanlovett
Copy link
Collaborator

@balajialg We don't have any concise info about just that, but we do have a few of the commands documented at https://docs.datahub.berkeley.edu/en/latest/admins/howto/new-hub.html#creating-a-new-filestore-instance.

Basically you should:

local$ gcloud compute ssh nfsserver-01 --zone=us-central1-b
nfsserver-01$ sudo install -d -o 1000 -g 1000 \
    /export/<hubname>-filestore/<hubname>/staging/_shared \
    /export/<hubname>-filestore/<hubname>/prod/_shared

We should probably have a separate section about this for creating shared data directories, right after the prod/shared directories are created.

@balajialg
Copy link
Contributor Author

balajialg commented Feb 2, 2024

Thanks a ton, @ryanlovett! Just made a commit that is related to your input

@ryanlovett
Copy link
Collaborator

Since this is for Econ 148 on the Data 100 hub, I feel like it should be a separate shared directory, rather than a subdirectory of _shared. For example, _shared-econ148. Otherwise those in Data 100 can read/write data in Econ 148's directory. Maybe that's not a problem?

@balajialg
Copy link
Contributor Author

@ryanlovett Fair concern! Created a separate shared directory for Econ 148

@ryanlovett
Copy link
Collaborator

@balajialg Okay, great. I also made one under data100/staging/.

@balajialg
Copy link
Contributor Author

Ah, missed that. Thanks @rylo! Can I merge this PR to staging and test it?

@ryanlovett
Copy link
Collaborator

Yes, I think it is ready to test.

@balajialg balajialg merged commit 332fb04 into berkeley-dsep-infra:staging Feb 3, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants