new pr rebased #314
new pr rebased #314
Conversation
…tialization & added to manifest
Implemented BaseActivity for generic data binding setup in AppCompatActivity subclasses
…andling - Replaced busy-waiting loop with ScheduledExecutorService for retry mechanism - Added HandlerThread for background operations and thread safety - Enhanced logging for better debugging and traceability - Improved error handling and timeout checks - Ensured more efficient scheduling of retries
- Enabled data binding in the project - Updated activity_splash_screen.xml to use data binding - Modified SplashScreenActivity to bind the layout using data binding - Refactored ClickHandler to work with data binding
…ture - Created a new folder named 'ui' - Moved all activities into the 'ui' folder - Updated package declarations and imports as necessary
…class in ui package -add ui binding - Refactored MainActivity class in the ui package to improve readability and maintainability - Introduced method extraction to reduce code duplication and improve modularity - Reorganized imports for better code organization - Added documentation for methods and important code blocks - Improved handling of internet connectivity checks and VPN service toggling - Enhanced error handling and logging for better debugging
# Conflicts: # app/src/main/java/org/bepass/oblivion/ui/LogActivity.java # app/src/main/res/drawable/button.xml # app/src/main/res/values/strings.xml
- Converted ThemeHelper class to a singleton to ensure a single point of management for the theme throughout the application. - Updated methods to instance methods instead of static methods. - Added getInstance method to provide the singleton instance. - Ensured compatibility with AppCompatDelegate night mode constants. - Improved code organization and readability.
add ColorUtils for handling colors func
add LocalController for handling local resource
|
is it ok ? @markpash |
|
@binaryb3ast There's no need to make new PRs, just rebase the branch you have on the |
Feat darkmode
|
i rebased |
|
@binaryb3ast This PR is quite large, but that's understandable given the number of valuable features and bug fixes it introduces. However, there's one small change that would be beneficial: ensuring the theme adapts seamlessly to the OS theme(dark / light mode).I'm waiting for this change and then merge it :) Thanks |
|
As far as I can tell, everything appears to be in order |
Well, the PR is alright. Just give me an hour to merge it. |
|
Cool, I'll get in touch via Twitter. I have your @ , here is mine @binarybeastt |
No description provided.