Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove valgrind in favor of ASAN, use mold for linking #64

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: remove valgrind in favor of ASAN, use mold for linking #64

wants to merge 2 commits into from

Conversation

marcluque
Copy link
Collaborator

@marcluque marcluque commented Nov 2, 2022 •
edited
Loading

  • remove valgrind in favor of ASAN because it has almost the same functionality but is a whole magnitude faster
  • Use mold for linking, this improves linking speed especially for the unit tests
  • Start caching apt packages to save time

@marcluque marcluque changed the title feat:run valgrind with unit tests in separate CI job & use mold for linking feat: run valgrind with unit tests in separate CI job & use mold for linking Nov 2, 2022
@marcluque marcluque force-pushed the feat-use-mold branch 13 times, most recently from 0de13e0 to f1d2577 Compare November 2, 2022 00:56
@marcluque marcluque added the dev-ops Something regarding DevOps label Nov 2, 2022
@marcluque marcluque force-pushed the feat-use-mold branch 5 times, most recently from 707ad96 to 0173a52 Compare November 2, 2022 02:10
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@marcluque marcluque force-pushed the feat-use-mold branch 9 times, most recently from 8cde592 to 8d0700c Compare November 2, 2022 13:13
@marcluque marcluque force-pushed the feat-use-mold branch 8 times, most recently from 0bd4cda to 4cb7796 Compare November 2, 2022 13:57
@marcluque marcluque changed the title feat: run valgrind with unit tests in separate CI job & use mold for linking feat: remove valgrind in favor of ASAN, use mold for linking, cache apt packages Nov 2, 2022
@marcluque marcluque changed the title feat: remove valgrind in favor of ASAN, use mold for linking, cache apt packages feat: remove valgrind in favor of ASAN, use mold for linking Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dev-ops Something regarding DevOps
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@marcluque