Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: bentoctl init-auth JSON error handling + compose up fix #276

Merged
merged 1 commit into from
Oct 8, 2024
Merged

fix: bentoctl init-auth JSON error handling + compose up fix #276

merged 1 commit into from
Oct 8, 2024

Conversation

davidlougheed
Copy link
Member

  • now properly waits for auth and gateway to be healthy before running commands
  • JSON parse errors are properly handled by the user creation utility

SanjeevLakhwani
SanjeevLakhwani approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@SanjeevLakhwani SanjeevLakhwani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@davidlougheed davidlougheed merged commit 658d477 into releases/v17.1 Oct 8, 2024
4 checks passed
@davidlougheed davidlougheed deleted the fix/bentoctl-init-auth branch October 8, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SanjeevLakhwani SanjeevLakhwani SanjeevLakhwani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidlougheed @SanjeevLakhwani