Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(grafana): authorization by group membership #261

Merged
merged 16 commits into from
Aug 29, 2024

Conversation

v-rocheleau
Copy link
Contributor

@v-rocheleau v-rocheleau commented Aug 27, 2024

Keycloak users can only signin to Grafana if they belong to a Grafana group with valid permissions in Keycloak.
Roles are as follow:

  • viewer: user can view dashboards
  • editor: user can create dashboards and explore the data
  • admin: user can manage users.

Grafana expects one of these roles to be present in the ID token when authenticating, otherwise the user is blocked.

Use bentoctl init-auth with the monitoring feature flag to create the Grafana client, it's roles, groups and mappers.

Also added the Grafana and Loki directories to bentoctl init-dirs.

Copy link
Member

@davidlougheed davidlougheed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reconcile with releases/v17 to add client creation helper + verbose argument(?)

py_bentoctl/auth_helper.py Outdated Show resolved Hide resolved
py_bentoctl/auth_helper.py Outdated Show resolved Hide resolved
py_bentoctl/auth_helper.py Outdated Show resolved Hide resolved
py_bentoctl/auth_helper.py Outdated Show resolved Hide resolved
py_bentoctl/auth_helper.py Outdated Show resolved Hide resolved
py_bentoctl/auth_helper.py Outdated Show resolved Hide resolved
py_bentoctl/auth_helper.py Outdated Show resolved Hide resolved
py_bentoctl/auth_helper.py Outdated Show resolved Hide resolved
Copy link
Member

@davidlougheed davidlougheed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@v-rocheleau v-rocheleau merged commit 405cd24 into releases/v17 Aug 29, 2024
2 checks passed
@v-rocheleau v-rocheleau deleted the chore/monitoring-hardening branch August 29, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants