Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: reference service 0.2.0 #240

Merged
merged 8 commits into from
Jun 10, 2024
Merged

feat: reference service 0.2.0 #240

merged 8 commits into from
Jun 10, 2024

Conversation

davidlougheed
Copy link
Member

No description provided.

@davidlougheed davidlougheed requested review from v-rocheleau and gsfk June 3, 2024 20:22
gsfk
gsfk reviewed Jun 5, 2024
View reviewed changes
Copy link
Member

@gsfk gsfk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only one annoying inline comment.

My local reference service was already on recent master, so I'm not able to test the migration currently.

docs/migrating_to_16.md Outdated Show resolved Hide resolved
v-rocheleau
v-rocheleau requested changes Jun 5, 2024
View reviewed changes
docs/migrating_to_16.md Outdated Show resolved Hide resolved
@davidlougheed davidlougheed requested review from gsfk and v-rocheleau June 5, 2024 20:35
v-rocheleau
v-rocheleau approved these changes Jun 10, 2024
View reviewed changes
Copy link
Contributor

@v-rocheleau v-rocheleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

etc/bento.env Outdated Show resolved Hide resolved
@davidlougheed davidlougheed merged commit df33e21 into releases/v16 Jun 10, 2024
2 checks passed
@davidlougheed davidlougheed deleted the feat/ref-service-0-2-0 branch June 10, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsfk gsfk gsfk approved these changes

@v-rocheleau v-rocheleau v-rocheleau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidlougheed @gsfk @v-rocheleau