refactor: gohan elasticsearch jvm heap options file #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidlougheed
requested changes
Mar 22, 2024
| @@ -47,6 +47,10 @@ lib/public/* | |||
| !lib/public/.gitkeep | |||
| !lib/public/docker-compose.public.yaml | |||
|
|
|||
| # gohan_elasticsearch | |||
| lib/gohan/es_jvm_options/* | |||
| !lib/gohan/es_jvm_options/.gitkeep | |||
There was a problem hiding this comment.
what happens when the user runs gohan without anything in here; does it work, or should we have a default editable file here?
There was a problem hiding this comment.
It works with nothing in it as well. This dir binds to /usr/share/elasticsearch/config/jvm.options.d/, which is always empty by default . Only files with the .options suffix are read by ES there, so whatever is in .gitkeep is ignored.
There was a problem hiding this comment.
Regarding the content of options file, per the docs:
Blank lines are ignored. Lines beginning with # are treated as comments and ignored. Lines that aren’t commented out and aren’t recognized as valid JVM arguments are rejected and Elasticsearch will fail to start.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced the Elasticsearch JVM heap size environment variable with the preffered configuration file approach.
https://www.elastic.co/guide/en/elasticsearch/reference/current/advanced-configuration.html#set-jvm-heap-size