Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require fugit >= 1.11.1 #1468

Closed
wants to merge 1 commit into from
Closed

Require fugit >= 1.11.1 #1468

wants to merge 1 commit into from

Conversation

jmettraux
Copy link

floraison/fugit#104

Prevent Fugit::Nat.parse choking on large input, peg at 256 chars

  spec.add_dependency "fugit", "~> 1.11", ">= 1.11.1"

Which requires fugit from 1.11.0 to 2.x not included and at least 1.11.1

floraison/fugit#104

Prevent Fugit::Nat.parse choking on large input, peg at 256 chars

```ruby
  spec.add_dependency "fugit", "~> 1.11", ">= 1.11.1"
```

Which requires fugit from 1.11.0 to 2.x not included and at least 1.11.1
@bensheldon
Copy link
Owner

I don't think this is a dependent gem's responsibility to pin this in their gemspec. I'm open if you can share documentation/policies somewhere that would recommend that gem's pin secure versions of dependencies. (for example, Rails frequently releases security patches, but I don't pin those in GoodJob's gemsepc)

Specifically for GoodJob, cron-schedules are intentionally designed not to accept user input, so I don't think GoodJob would be effected by malicious values.

@jmettraux
Copy link
Author

Specifically for GoodJob, cron-schedules are intentionally designed not to accept user input, so I don't think GoodJob would be effected by malicious values.

Good for you, your project can't be affected then. I'm closing this request.

Thanks for your time.

@jmettraux jmettraux closed this Aug 16, 2024
@bensheldon
Copy link
Owner

thanks for the heads up though! Are you planning to publish a CVE on it? That'd be my recommendation because then automated tooling will pick it up and report it.

@jmettraux
Copy link
Author

Thanks for the recommendation, I will try to do it.

@bensheldon
Copy link
Owner

There's some details at the bottom of: https://guides.rubygems.org/security/

(disclosure: I work at GitHub) You can do so pretty easily through your GitHub project: https://docs.github.com/en/code-security/security-advisories/working-with-repository-security-advisories/about-repository-security-advisories#cve-identification-numbers

@jmettraux
Copy link
Author

@jmettraux
Copy link
Author

CVE drafted and requested. That was slick so far. Thanks for your guidance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants