check FollowLink errors

connection#FollowLink issues an additional HTTP call which may fail if ovirt-engine suddenly becomes unavailable. Currently it will panic, but once [1] is merged, an error will be returned. [1] oVirt/ovirt-engine-sdk-go#215 Signed-off-by: Benny Zlotnik <[email protected]>
bennyz · Oct 5, 2020 · c4effc5 · c4effc5
1 parent c4cddfb
commit c4effc5
Showing 1 changed file with 11 additions and 2 deletions.
diff --git a/pkg/operator/storageclass_controller.go b/pkg/operator/storageclass_controller.go
@@ -97,7 +97,12 @@ func (c *OvirtStrogeClassController) getStorageDomain(ctx context.Context) (stri
 
 	for _, attachment := range attachments.MustAttachments().Slice() {
 		if attachment.MustBootable() {
-			d, _ := conn.FollowLink(attachment.MustDisk())
+			d, err := conn.FollowLink(attachment.MustDisk())
+			if err != nil {
+				klog.Errorf(fmt.Sprintf("Failed to follow disk: %v", err))
+				return "", err
+			}
+
 			disk, ok := d.(*ovirtsdk.Disk)
 			klog.Info(fmt.Sprintf("Extracting Storage Domain from disk: %s", disk.MustId()))
 
@@ -106,7 +111,11 @@ func (c *OvirtStrogeClassController) getStorageDomain(ctx context.Context) (stri
 				return "", err
 			}
 
-			s, _ := conn.FollowLink(disk.MustStorageDomains().Slice()[0])
+			s, err := conn.FollowLink(disk.MustStorageDomains().Slice()[0])
+			if err != nil {
+				klog.Errorf(fmt.Sprintf("Failed to follow Storage Domain: %v", err))
+				return "", err
+			}
 			sd, ok := s.(*ovirtsdk.StorageDomain)
 
 			klog.Info(fmt.Sprintf("Fetched Storage Domain %s", sd.MustName()))