Extra NaN check for conjugate gradient ALS model #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With synthetic data and a large regularization parameter, the CG ALS model would converge so that some users/items factors had 0 vectors for solutions. The CG update would fail in this case setting all the factors to NaN. (#106). Fix by detecting when this would occur and aborting. A previous check handled the case inside the loop: #19 (comment), this handles the case where rsold = 0 entering the loop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With synthetic data and a large regularization parameter, the CG ALS model
would converge so that some users/items factors had 0 vectors for solutions.
The CG update would fail in this case setting all the factors to NaN. (#106).
Fix by detecting when this would occur and aborting. A previous
check handled the case inside the loop: #19 (comment)