Skip to content

Commit

Permalink
Extra NaN check for conjugate gradient ALS model
Browse files Browse the repository at this point in the history
With synthetic data and a large regularization parameter, the CG ALS model
would converge so that some users/items factors had 0 vectors for solutions.
The CG update would fail in this case setting all the factors to NaN.
(#106).

Fix by detecting when this would occur and aborting. A previous
check handled the case inside the loop:
#19 (comment)
  • Loading branch information
benfred committed May 23, 2018
1 parent 5ceadba commit e2ac868
Show file tree
Hide file tree
Showing 3 changed files with 1,066 additions and 894 deletions.
Loading

0 comments on commit e2ac868

Please sign in to comment.