This repository has been archived by the owner on Feb 1, 2018. It is now read-only.
Adding in the ability to specify --junit and have the build produce junit xml output #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let me know what you think about this. The branch is pulled off of 2.1.0.rc.2 because there are 2 failing tests on master.
When I first got into the code there was a lot of magic going on. I could not tell what methods were being called on the "formatters" on purpose and what on accident.
With the way I implemented it I added a generic method_missing method to the fanout_formatter at first but after running the bwoken tests on a device I started getting errors that didn't make sense to me.
I then changed it so that the fanout formatter only receives messages that it is currently forwarding on, and the formatter can decide whether it wants to implement the method or not.
It would be very simple to do this for XUnit output as well if someone still wants that done.