Added option to use Rust benchmark names with spaces #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @Razican! Thank you for your contribution! Could you please add a test case that would fail with the current regexp and is fixed by your change? |
|
I'm glad though that you're going back to using this action :) |
Sure! Where would be the best place to put it? |
|
I added some tests, but not sure if this is the correct place, or if something else is missing, let me know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using Criterion for Rust benchmarks, you can use any string as a benchmark name, but this action doesn't allow for this option. We have a repo with strings for these benchmark names, and we would need this feature.