Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Replica #135

Closed
benbjohnson opened this issue Mar 24, 2021 · 2 comments · Fixed by #188
Closed

Refactor Replica #135

benbjohnson opened this issue Mar 24, 2021 · 2 comments · Fixed by #188
Labels
enhancement New feature or request
Milestone
v0.3.5

Comments

@benbjohnson
Copy link
Owner

benbjohnson commented Mar 24, 2021 •
edited
Loading

Currently, the file and s3 replicas share a decent amount of logic but differ in some important implementation details. This could be improved to consolidate common functionality into a concrete Replica type and move platform-specific functionality into a ReplicaClient interface.

This refactor also needs to support both push and pull models for the upcoming http replica type. Once this refactor is complete, a native Azure Blob Storage implementation can be added.
@benbjohnson benbjohnson added the enhancement New feature or request label Mar 24, 2021
@benbjohnson benbjohnson added this to the v0.3.5 milestone Mar 24, 2021
@yanc0
Copy link

yanc0 commented Mar 25, 2021

Great enhancement here ! I think the GCS can be part of the refactoring to. The S3 compatibility mode provided by Google is really scary. #74

@benbjohnson
Copy link
Owner Author

@yanc0 Yes, that's a good point. Using the GCS client directly would make a lot more sense after the refactor. 👍

@benbjohnson benbjohnson mentioned this issue Mar 26, 2021
Closed
@benbjohnson benbjohnson mentioned this issue May 19, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.3.5
Development

Successfully merging a pull request may close this issue.

Refactor replica system benbjohnson/litestream
2 participants
@benbjohnson @yanc0