Make sure null conditionals break like regular expressions #593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I still need to look at the result of this change on csharpier-repos. Creating the testing PR is taking significantly longer than it should. I created #594 to look into it. |
|
I just noticed that the this.CallMethod_____________________()!.CallMethod_____________________()!.CallMethod_____________________();I will fix that tomorrow. |
shocklateboy92
approved these changes
Feb 7, 2022
| @@ -2,6 +2,11 @@ namespace CSharpier.DocTypes; | |||
|
|
|||
| internal abstract class Doc | |||
| { | |||
| public override string ToString() | |||
| { | |||
| return DocSerializer.Serialize(this); | |||
There was a problem hiding this comment.
I'm surprised it took this long for that to happen 😁
There was a problem hiding this comment.
So nice for debugging, I don't know why I didn't look into how to do this like 12 months ago.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #561