use relative file path in CommandLineFormatter (#680)

* use relative file path in CommandLineFormatter This changes the format of the file name to add a leading "." so that the path is a relative path instead of an absolute path. Modern terminal programs allow control-clicking on paths to jump to a file, so if this is a relative path, we can jump to the file. If it is printed as an absolute path, this doesn't work. * Test to cover subdirectory relative path * Modifying logging to use relative or absolute path based on what is input to cli * Fix warning * Fixing another bug Co-authored-by: Bela VanderVoort <[email protected]>
belav · Jun 13, 2022 · a56a47a · a56a47a
1 parent a62195e
commit a56a47a
Show file tree

Hide file tree

Showing 5 changed files with 225 additions and 160 deletions.
diff --git a/Src/CSharpier.Cli.Tests/CliTests.cs b/Src/CSharpier.Cli.Tests/CliTests.cs
@@ -174,7 +174,7 @@ public async Task With_Check_Should_Write_Unformatted_File()
         result.Output
             .Replace("\\", "/")
             .Should()
-            .StartWith("Warning /CheckUnformatted.cs - Was not formatted.");
+            .StartWith("Warning ./CheckUnformatted.cs - Was not formatted.");
         result.ExitCode.Should().Be(1);
     }
 
@@ -203,21 +203,20 @@ public async Task Should_Format_Multiple_Piped_Files(string lineEnding)
         results[1].Should().Be(formattedContent2);
     }
 
-    [Test]
-    public async Task Should_Write_Error_With_Multiple_Piped_Files()
+    [TestCase("InvalidFile.cs", "./InvalidFile.cs")]
+    [TestCase("./InvalidFile.cs", "./InvalidFile.cs")]
+    public async Task Should_Write_Error_With_Multiple_Piped_Files(string input, string output)
     {
         const string invalidFile = "public class ClassName { ";
 
         var result = await new CsharpierProcess()
             .WithArguments("--pipe-multiple-files")
-            .WithPipedInput($"InvalidFile.cs{'\u0003'}{invalidFile}{'\u0003'}")
+            .WithPipedInput($"{input}{'\u0003'}{invalidFile}{'\u0003'}")
             .ExecuteAsync();
 
         result.ErrorOutput
             .Should()
-            .Be(
-                $"Error /InvalidFile.cs - Failed to compile so was not formatted.{Environment.NewLine}"
-            );
+            .Be($"Error {output} - Failed to compile so was not formatted.{Environment.NewLine}");
         result.ExitCode.Should().Be(1);
     }