Getting pattern matching formatting straightened out.

closes #154

Src/CSharpier.Tests/TestFiles/IsPatternExpression/IsPatternExpressions.cst

@@ -12,14 +12,6 @@ class ClassName
             return;
         }
 
-        if (
-            MethodKind
-                is not (MethodKind.Ordinary_________________________
-                    or MethodKind.LocalFunctionn)
-        ) {
-            return;
-        }
-
         if (expr is < 'A' or > 'Z')
         {
             return;
@@ -35,14 +27,14 @@ class ClassName
         var useLine =
             node.OperatorToken.Kind()
                 is SyntaxKind.BarBarToken
-                    or SyntaxKind.BarToken
-                    or SyntaxKind.AmpersandAmpersandToken
-                    or SyntaxKind.AmpersandToken
-                    or SyntaxKind.PlusToken;
+                or SyntaxKind.BarToken
+                or SyntaxKind.AmpersandAmpersandToken
+                or SyntaxKind.AmpersandToken
+                or SyntaxKind.PlusToken;
 
         if (
-            Nullable.GetUnderlyingType111111111111111(typeof(T)) is Type innerType
-            && innerType.IsEnum
+            someRandomValue___________________ is SomeRandomType someRandomType
+            && someRandomType.IsEnum
         ) {
             return;
         }
@@ -56,5 +48,105 @@ class ClassName
         {
             return;
         }
+
+        if (
+            someValue_________________________ is SomeType_________________ someType
+            && someType.SomeProperty
+        ) { }
+
+        var value =
+            someOtherValue
+                is SomeType___________________
+                {
+                    SomeProperty: SomeOtherType_____________________________________________
+                }
+                or SomeThirdType___________;
+
+        var value =
+            someOtherValue
+                is SomeType___________________
+                {
+                    SomeProperty: SomeOtherType_____________________________________________,
+                    AnotherProperty: SomeType
+                }
+                or SomeThirdType___________;
+
+        var value =
+            someOtherValue
+                is SomeType___________________
+                {
+                    SomeProperty: SomeType or SomeOtherType
+                };
+
+        var value =
+            someOtherValue
+                is SomeType___________________
+                {
+                    SomeProperty: SomeLongType_______________
+                        or SomeOtherLongType___________________
+                };
+
+        var value =
+            someOtherValue
+                is SomeType___________________
+                or SomeOtherType___________________
+                or SomeThirdType___________
+            && someLongValue_________________;
+
+        if (someOtherValue is (SomeType or SomeOtherType))
+        {
+            return;
+        }
+
+        if (someOtherValue is not (SomeType or SomeOtherType))
+        {
+            return;
+        }
+
+        if (
+            someOtherValue_____________
+            is (SomeLongType_____________ or SomeOtherLongType_____________)
+        ) {
+            return;
+        }
+
+        if (
+            someOtherValue_____________
+            is not (SomeLongType_____________ or SomeOtherLongType_____________)
+        ) {
+            return;
+        }
+
+        if (
+            node is SomeType_______________
+            {
+                SomeProperty: SomeOtherType_____________________________
+            }
+        ) {
+            return;
+        }
+
+        if (
+            node is PrefixUnaryExpressionSyntax
+            {
+                Operand: ParenthesizedExpressionSyntax
+                {
+                    Expression: IsPatternExpressionSyntax or IsPatternExpressionSyntax
+                },
+            }
+        ) {
+            return;
+        }
+
+        if (
+            !(
+                node is PrefixUnaryExpressionSyntax
+                {
+                    Operand: ParenthesizedExpressionSyntax or IsPatternExpressionSyntax
+                }
+            )
+        ) {
+            return;
+        }
     }
 }

Src/CSharpier.Tests/TestFiles/SwitchExpression/SwitchExpressions.cst

@@ -50,7 +50,28 @@ class ClassName
             or AnotherObject
             or OrEvenSomeOtherObject_________________
               => CallSomeMethod(someValue),
+            SomeOtherObject
+            {
+                SomeProperty: SomeOtherProject
+            }
+            or AnotherObject
+              => CallSomeMethod(someValue),
+            AnotherObject
+            or SomeOtherObject
+            {
+                SomeProperty: SomeOtherProject
+            }
+              => CallSomeMethod(someValue),
             _ => CallSomeMethod(someValue)
         };
+
+        return someValue switch
+        {
+            { IsParameter: true, } => noExtraLineAfterThis,
+            {
+                IsParameter: someLongValue____________________________________________,
+            }
+              => someOtherValue
+        };
     }
 }

Src/CSharpier/DocTypes/Doc.cs

@@ -96,6 +96,11 @@ public static IndentDoc Indent(params Doc[] contents) =>
 
         public static IndentDoc Indent(List<Doc> contents) => new() { Contents = Concat(contents) };
 
+        public static Doc IndentIf(bool condition, Concat contents)
+        {
+            return condition ? Doc.Indent(contents) : contents;
+        }
+
         public static IfBreak IfBreak(
             Doc breakContents,
             Doc flatContents,

Src/CSharpier/SyntaxPrinter/SyntaxNodePrinters/BinaryExpression.cs

@@ -71,7 +71,8 @@ private static List<Doc> PrintBinaryExpression(SyntaxNode node)
                 var shouldGroup =
                     binaryExpressionSyntax.Kind() != binaryExpressionSyntax.Parent!.Kind()
                     && binaryExpressionSyntax.Left.GetType() != binaryExpressionSyntax.GetType()
-                    && binaryExpressionSyntax.Right.GetType() != binaryExpressionSyntax.GetType();
+                    && binaryExpressionSyntax.Right.GetType() != binaryExpressionSyntax.GetType()
+                    && binaryExpressionSyntax.Left is not IsPatternExpressionSyntax;
 
                 // nested ?? have the next level on the right side, everything else has it on the left
                 var binaryOnTheRight =

Src/CSharpier/SyntaxPrinter/SyntaxNodePrinters/BinaryPattern.cs

@@ -1,3 +1,4 @@
+using System.Collections.Generic;
 using CSharpier.DocTypes;
 using Microsoft.CodeAnalysis.CSharp.Syntax;
 
@@ -7,12 +8,67 @@ public static class BinaryPattern
     {
         public static Doc Print(BinaryPatternSyntax node)
         {
-            return Doc.Concat(
-                Node.Print(node.Left),
-                Doc.Line,
-                Token.PrintWithSuffix(node.OperatorToken, " "),
-                Node.Print(node.Right)
+            return Doc.IndentIf(
+                node.Parent is SubpatternSyntax,
+                Doc.Concat(
+                    Node.Print(node.Left),
+                    Doc.Line,
+                    Token.PrintWithSuffix(node.OperatorToken, " "),
+                    Node.Print(node.Right)
+                )
             );
         }
     }
 }
+/*
+
+// review this, there are more edge cases
+https://github.com/belav/aspnetcore/pull/25/files
+
+// what should this do?
+if (
+    someOtherValue_____________
+    is (SomeLongType_____________________________________
+        or SomeLongType_____________________________________)
+) {
+    return;
+}
+
+// this is uh, ugly, maybe just don't indent the { } ?
+// also the new break fore is makes this version uglier, maybe break before is should only be for variable stuff?
+if (
+    !(
+        node is PrefixUnaryExpressionSyntax
+            {
+                Operand: ParenthesizedExpressionSyntax
+                    {
+                        Expression: IsPatternExpressionSyntax
+                            {
+                                Pattern: DeclarationPatternSyntax,
+                            } isPattern,
+                    },
+            } notExpression
+    )
+) {
+    return;
+}
+
+// could this be improved??
+    return someValue switch
+    {
+        OrEvenSomeOtherObject_________________
+          => CallSomeMethod(someValue),
+        SomeOtherObject
+        {
+            SomeProperty: SomeOtherProject
+        }
+        or AnotherObject
+          => CallSomeMethod(someValue),
+        AnotherObject
+        or SomeOtherObject
+        {
+            SomeProperty: SomeOtherProject
+        }
+          => CallSomeMethod(someValue)
+    }
+*/

Src/CSharpier/SyntaxPrinter/SyntaxNodePrinters/IsPatternExpression.cs

@@ -8,12 +8,20 @@ public static class IsPatternExpression
     {
         public static Doc Print(IsPatternExpressionSyntax node)
         {
+            var useSpace =
+                node.Parent is IfStatementSyntax or ParenthesizedExpressionSyntax
+                && node.Pattern is not (ParenthesizedPatternSyntax or UnaryPatternSyntax);
+
             return Doc.Group(
                 Node.Print(node.Expression),
-                Doc.Indent(
-                    Doc.Line,
-                    Token.PrintWithSuffix(node.IsKeyword, " "),
-                    Doc.Indent(Node.Print(node.Pattern))
+                Doc.IndentIf(
+                    node.Parent is not (IfStatementSyntax or ParenthesizedExpressionSyntax),
+                    Doc.Concat(
+                        useSpace ? " " : Doc.Line,
+                        Token.Print(node.IsKeyword),
+                        node.Pattern is RecursivePatternSyntax { Type: null } ? Doc.Null : " ",
+                        Node.Print(node.Pattern)
+                    )
                 )
             );
         }

Src/CSharpier/SyntaxPrinter/SyntaxNodePrinters/ParenthesizedPattern.cs

@@ -8,7 +8,7 @@ public static class ParenthesizedPattern
     {
         public static Doc Print(ParenthesizedPatternSyntax node)
         {
-            return Doc.Concat(
+            return Doc.Group(
                 Token.Print(node.OpenParenToken),
                 Node.Print(node.Pattern),
                 Token.Print(node.CloseParenToken)