Cleaning up formatting of fors with empty statements (#528)

closes #523
belav · Dec 21, 2021 · 16f768e · 16f768e
1 parent 7876be6
commit 16f768e
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 3 deletions.
diff --git a/Src/CSharpier.Tests/FormattingTests/TestFiles/ForStatements.cst b/Src/CSharpier.Tests/FormattingTests/TestFiles/ForStatements.cst
@@ -13,7 +13,22 @@ class ClassName
             break;
         }
 
-        for (;;)
+        for (; ; )
+        {
+            break;
+        }
+
+        for (var x = 1; ; )
+        {
+            break;
+        }
+
+        for (var x = 1; x < 0; )
+        {
+            break;
+        }
+
+        for (var x = 1; ; x++)
         {
             break;
         }

diff --git a/Src/CSharpier/SyntaxPrinter/SyntaxNodePrinters/ForStatement.cs b/Src/CSharpier/SyntaxPrinter/SyntaxNodePrinters/ForStatement.cs
@@ -23,9 +23,9 @@ public static Doc Print(ForStatementSyntax node)
                         ),
                         node.Condition != null
                           ? Doc.Concat(Doc.Line, Node.Print(node.Condition))
-                          : Doc.SoftLine,
+                          : Doc.Line,
                         Token.Print(node.SecondSemicolonToken),
-                        node.Incrementors.Any() ? Doc.Line : Doc.SoftLine,
+                        Doc.Line,
                         Doc.Group(
                             Doc.Indent(
                                 SeparatedSyntaxList.Print(node.Incrementors, Node.Print, Doc.Line)