This repository was archived by the owner on May 31, 2020. It is now read-only.
Builtins and some Float operators #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add the default AttributeError to org.python.types.Super and org.python.types.Object.
- This was not erroring on javac for jdk1.8.
- Add the name to Method annotation to make it be callable as float() instead of float_cast() - Add implementation in Bool and Str
- This was breaking tests for exception messages that end with one or more trailing spaces, as they accidentally get 'stripped' off as part of the \s special sequence which includes newlines and spaces. - Instead, use the MULTILINE mode, start the regex with ^ to match each newline, and then include the EOL at the back with `\r?\n` to ensure that it is not left behind in the exception string after replacing.
- Quote the value with single quotes only when it's non-empty. - Mark test as passing.
- Largely copied from Int, with some minor modifications. - Mark passing tests as implemented.
- Uses the newly implemented floordiv and mod - Add tests
- Replace the "unsupported operand type(s) for //" message with "unsupported operand type(s) for divmod()"
- Mark tests as passing.
- Mark tests as passing.
- Wire up builtin org.Python.pow() with args and third argument checking - Implement for Float and Bool (latter delegating to Int)
- Test builtin functions more easily and thoroughly with this test case
- Mark tests as passing.
- This is much more thorough than the manually written tests previously in DivmodTests.
|
Fantastic work - thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I better send this PR before it gets any bigger.
any(), bin(), int(), chr(), float(), hex(), bin(), oct()divmod(), pow()__floordiv__(),__mod__()(to implementdivmod())divmod()parameters, as it was taking too long to slowly write all the permutations and search out the edge cases. This shook out ~3 bugs in the implementation.Refs #76.