-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Python version coverage to template CI. #55
Conversation
52e536b
to
b237d0a
Compare
b237d0a
to
466d402
Compare
@mhsmith The test failures for 3.11 are to be expected; once you've published 3.11 support to Maven Central, you should be to able to re-start the failed jobs and get a clean board for merge. |
I haven't published 3.11.0 to Maven Central yet, because there's something strange about the file sizes which didn't happen with the 3.11 RC:
arm64-v8a/_pickle.so and x86/_queue.so have both massively increased in size. In fact, they're both about the same size as libpython, which suggests they've somehow ended up statically linked against it. I'll look into this tomorrow. |
It looks like python/cpython#93977 introduced a bug that when cross-compiling, the Makefile no longer requires libpython to be built before it calls setup.py to build the stdlib binary modules. But exactly what happens is non-deterministic because of the parallel build. setup.py might fail to build all modules, or only some of them, or it might link some against libpython.a and some against libpython.so. The reason I didn't notice this before is that after @freakboy3742: You might want to check whether this affects iOS as well. I worked around it with this patch. |
@mhsmith That's for the heads up; that's a nasty one. Looks like the Apple builds aren't affected though - the Apple Support package Makefile don't enable the parallel build options in the CPython makefile, so the core library is always built before the stdlib is compiled. |
Adds python versions to the test matrix for template builds.
PR Checklist: