Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add season number to Wide episodes view #881

Merged
merged 2 commits into from
Jan 18, 2023

Conversation

sPOiDar
Copy link
Contributor

@sPOiDar sPOiDar commented Nov 20, 2022

This allows flattened episode lists to be usable, otherwise there's no way to distinguish between same numbered episodes across different seasons.

@sPOiDar sPOiDar force-pushed the add_season_to_wide_episodes branch 2 times, most recently from cf4ce13 to 9a4ef07 Compare November 23, 2022 09:33
This allows flattened episode lists to be usable, otherwise there's no
way to distinguish between same numbered episodes across different
seasons.
@sPOiDar sPOiDar force-pushed the add_season_to_wide_episodes branch from 9a4ef07 to 86384c1 Compare November 25, 2022 11:50
@beatmasterRS beatmasterRS added Kodi 19 Kodi 19 Wontadd This feature or improvement will not be added Kodi 20 Kodi 20 labels Jan 14, 2023
@sPOiDar
Copy link
Contributor Author

sPOiDar commented Jan 15, 2023

I take it that since this was closed as Wontadd there's no interest in having Wide view work for flattened episodes?

@beatmasterRS
Copy link
Owner

beatmasterRS commented Jan 15, 2023

Sorry, I did not think of the option "Show all episodes". But still it doesn't look nice to me, because if you are in season < 10, there is too much free space between episode number and title. Maybe you could use animations to push the information on the right further to the left depending on the season number?

@beatmasterRS beatmasterRS reopened this Jan 15, 2023
@beatmasterRS
Copy link
Owner

Maybe you could use

Integer.IsGreater(info,number)

for checking if the season os > 9 and a slide animation?

@beatmasterRS beatmasterRS removed the Wontadd This feature or improvement will not be added label Jan 15, 2023
@beatmasterRS
Copy link
Owner

screenshot01311

@sPOiDar
Copy link
Contributor Author

sPOiDar commented Jan 15, 2023

Hmm, is that screenshot actually using this patch? The padding should end up on the left of the SxEE numbers, not the right, since this patch changes the alignment of that element to right, which looks better than the above screenshot I think.

The spacing has to be consistent though, otherwise when you reach S10+ the alignment will be mismatched, so I don't think the animation option would work?

I don't have a desktop kodi env that I can easily take a screenshot from right now, or I'd post some pictures to better illustrate.

@beatmasterRS
Copy link
Owner

Could you please test this branch: https://github.com/beatmasterRS/skin.arctic.zephyr.mod/tree/pr-881-1 ?

I have included some anmation conditions. With that the free space is gone.

@sPOiDar
Copy link
Contributor Author

sPOiDar commented Jan 17, 2023

I tested that branch, and it did what I expected it would - the alignment of the titles is different between S9 and S10. I can't take screenshots from my main Kodi instance, so I had to resort to taking pics to illustrate the difference.

From the linked branch:
P_20230117_220902

This PR:
P_20230117_221036

@beatmasterRS beatmasterRS merged commit 37fed5e into beatmasterRS:master Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Kodi 19 Kodi 19 Kodi 20 Kodi 20
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants