-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for SetupIntent #522
Add support for SetupIntent #522
Conversation
Tests are fixed! Mind merging in master? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! Just a quick review and everything looks pretty close to good!
Hi guys, |
Thanks, I'll have look at these. It seems they're still developing it, the list option wasn't there when I implemented it! |
@moomerman Let me know if you have time to round this one out this week! Looking to release 2.5 by the end of the week. |
Hi everyone, what are the chances we can get this included soon? The EU SCA deadline is fast approaching on September 14th, and we need to use the SetupIntents API to properly support it. 😅 For now, I'm going to attempt to use the branch directly, hoping it works ok! Thanks for all the hard work on this! |
For SCA this may also be needed #539 Feel free to cherry-pick that commit into this branch before merging. |
@snewcomer sorry was away last week so didn't get a chance to make v2.5. I've addressed everything now, have left as separate commits for review but let me know if it's good and I'll squash them. I wasn't sure about the last commit |
What an amazing PR. Thank you thank you! |
2.6 was released! Thank you @maartenvanvliet and @moomerman! Amazing work |
This PR adds support for the Stripe SetupIntent object.
/setup-intents
endpoint support.