Fix the broken session expiration test #73
Merged
+4
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The session expiration test was broken: even if you removed the call to :timer.sleep(1000) the test would still pass. This is because each of the two requests used a different secret, meaning that the second conn didn't have access to the session from the first in any case. By using sign_conn_with/3 instead of sign_conn/2, this test can use the same secret for both conns, ensuring that this test actually tests what it claims to be testing.
germsvel
approved these changes
Mar 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While writing the test for #72, I noticed that the test for session expiration was broken: even if you removed the call to
:timer.sleep(1000)the test would still pass.By not reusing the secret between the two requests, the second request couldn't access the session from the first, meaning that even if the session hadn't expired it still wouldn't be accessible.
This PR fixes this test, so that it will fail properly if the session expiration doesn't work.