-
-
Notifications
You must be signed in to change notification settings - Fork 474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [CommandBar] supports setting directions if needed. #872
Conversation
Sorry, this version can't cover all options, uch as If you agree with this feature, I will make another PR when all options are compatible. Sorry for the previous mistake again. |
I like the concept and would love to see this working :) |
@bdlukaa |
I'm not sure how resolving the mouse scroll delta for a better scrolling effect works for vertical scroll views tho. iirc, Flutter is working on 2D scrolling, which should affect how horizontal scrolling behaves and we, sometime soon, may get rid of |
Does this mean that Here are some effects of using vertical scrolling.
20230705_113435.mp4
20230705_113510.mp4 |
What I don't quite understand is why this event only triggers when it reaches the top and bottom. Do I need to make any further changes? |
I tried your implementation with every example in https://bdlukaa.github.io/fluent_ui/#/surfaces/command_bar, but most of them throw a render box issue :/ |
In my case, the exterior has height constraints. Is it possible that this is the reason?Or am I missing any key elements that are not compatible with 😂 |
You can wrap the scroll view in a ScrollConfiguration(
behavior: ScrollConfiguration.of(context).copyWith(scrollbars: false),
child: ...,
), |
@bdlukaa |
Add direction to CommandBar to support verticality.
![image](https://private-user-images.githubusercontent.com/15630211/250273862-a287a6e5-5842-43d1-8515-34b4158de7ed.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk2NzE1MjcsIm5iZiI6MTczOTY3MTIyNywicGF0aCI6Ii8xNTYzMDIxMS8yNTAyNzM4NjItYTI4N2E2ZTUtNTg0Mi00M2QxLTg1MTUtMzRiNDE1OGRlN2VkLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE2VDAyMDAyN1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWZlNzNiZGM4MDYxMTdmYjIxM2JkN2YxZWM3MWI4ZGU3OGI1ZThjNWNkY2U2MTlhZDYzZDhmZjRjNjdiNzRiMWEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.7FAouQ_hHd6GGV7nMEF6sRf5X58WLYfBKRHyHJruk68)
Sometimes, we need to place the command bar on the side.
Just like this:
When we set
direction
toAxis.vertical
, theisCompact
will default to true, if it is not set.Pre-launch Checklist
CHANGELOG.md
with my changes