-
-
Notifications
You must be signed in to change notification settings - Fork 474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use PageView to build the view content #607
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It works like a charm, but some changes are needed in order to make paneBodyBuilder works (again) |
This comment was marked as resolved.
This comment was marked as resolved.
3 tasks
henry2man
reviewed
Nov 16, 2022
it didnt work even when i used pageBuilder...i'll try to upgrade to the latest upgrade of the package and see if it will work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PaneItem.bodyKey
is now assigned to everyPaneItem.body
to preserve its state. Improved, fundamentally, how the current body management works. Additionally,.bodyKey
can be used to find measurements for the body content, if needed in the future.Fixed #604
Pre-launch Checklist
CHANGELOG.md
with my changes