Fix unnecessary NavigationAppBar leading icon when no NavigationPane was provided #551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix NavigationAppBar unnecessary leading icon when NavigationPane is not provided
add bug-fix description for unnecessary NavigationAppBar leading icon
bdlukaa
approved these changes
Oct 1, 2022
bdlukaa
approved these changes
Oct 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After updating from version 3.11 to 4.0.1 I encountered a problem with
NavigationAppBar.For screen width <= 640 it was showing an icon for openin'/closing the pane which is the expected behavior, but the issue is I did not provide a
NavigationPanefor theNavigationViewso the icon is unnecessary.I found in the source code that an additional leading icon is added to the app bar but without checking whether there's a pane or not.
What I did basically is adding an If statement before adding the additional leading.
It's a small bug, please add a fix for it if the pull request is missing something.
Pre-launch Checklist
CHANGELOG.mdwith my changes