Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add useInheritedMediaQuery to FluentApp #211

Merged
merged 2 commits into from
Mar 6, 2022
Merged

Add useInheritedMediaQuery to FluentApp #211

merged 2 commits into from
Mar 6, 2022

Conversation

henry2man
Copy link
Contributor

@henry2man henry2man commented Mar 4, 2022 •
edited
Loading

A simple one. Just add useInheritedMediaQuery to FluentApp

Motivation: Use with device_preview package (https://pub.dev/packages/device_preview)

Pre-launch Checklist

  • I have run dartfmt on all changed files
  • I have updated CHANGELOG.md with my changes
  • I have run "optimize/organize imports" on all changed files
  • I have addressed all analyzer warnings as best I could
  • I have added/updated relevant documentation
  • I have run flutter pub publish --dry-run and addressed any warnings

@henry2man henry2man changed the title Add useInheritedMediaQuery to FluentApp Add useInheritedMediaQuery to FluentApp Mar 4, 2022
bdlukaa
bdlukaa requested changes Mar 4, 2022
View reviewed changes
lib/src/app.dart Outdated Show resolved Hide resolved
@henry2man @bdlukaa
Update lib/src/app.dart
4b9a1a7 
Co-authored-by: Bruno D'Luka <[email protected]>
bdlukaa
bdlukaa approved these changes Mar 6, 2022
View reviewed changes
Copy link
Owner

@bdlukaa bdlukaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bdlukaa bdlukaa merged commit 4c448bb into bdlukaa:master Mar 6, 2022
@mesharkw mesharkw mentioned this pull request Jul 12, 2023
Closed
dev-hann added a commit to dev-hann/fluent_ui that referenced this pull request Sep 18, 2023
@dev-hann
Add useInheritedMediaQuery to FluentApp (bdlukaa#211)
71013dc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdlukaa bdlukaa bdlukaa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@henry2man @bdlukaa