Selection controls #196
Merged
Selection controls #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdlukaa
commented
Feb 23, 2022
| @@ -119,9 +117,7 @@ class _FluentTextSelectionControlsToolbar extends StatefulWidget { | |||
| } | |||
|
|
|||
| class _FluentTextSelectionControlsToolbarState | |||
| extends State<_FluentTextSelectionControlsToolbar> | |||
| with SingleTickerProviderStateMixin { | |||
| late AnimationController _ac; | |||
There was a problem hiding this comment.
Removed the animation controller since it's no longer used on Win UI 3
WinXaito
approved these changes
Feb 24, 2022
There was a problem hiding this comment.
Great work !
The cursor color doesn't follow accent color:
And: cursorHeight property has no effect
And the others point are certainly flutter-related:
- Customize cursorBlink speed ?
- Triple clic selection
- Right clic outside the selection deselect the content
And maybe doc ? 😅
Documentation is already provided for the selection controls. TextBox already uses |
It should be the inactive color tho |
Anyway, just no "blue" if the accent color is other ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-launch Checklist
dartfmton all changed filesCHANGELOG.mdwith my changesflutter pub publish --dry-runand addressed any warnings