This repository has been archived by the owner on May 4, 2023. It is now read-only.
Improve detail VC layout during animation #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix layout jumps by calling `layoutIfNeeded` within the animation block.
|
Sorry for the delay in tending to this PR. Perhaps I'm missing something, but I can't see any difference made by calling layoutIfNeeded. Is there a particular use case that I should be looking at? |
|
It improves the animation of the detail view while hiding / showing the master VC. |
|
Oh wow, you're quite right! Very noticeable difference. I was focusing on the animation of the master VC when showing/hiding, not on the detail VC, so thanks for the clarification. I'll get this merged in right away. |
bdbergeron
added a commit
that referenced
this pull request
Jul 20, 2014
Improve detail VC layout during animation
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix layout jumps by calling
layoutIfNeededwithin the animation block.