Skip to content

Commit

Permalink
Remove rounding of slider velocity multiplier on juice streams
Browse files Browse the repository at this point in the history
Compare: ppy#26616

This came up elsewhere, namely in
ppy#28277 (comment).

As it turns out, at least one beatmap among those whose scores had
unexpected changes in total score, namely
https://osu.ppy.sh/beatmapsets/971028#fruits/2062131, was using slider
velocity multipliers that were not a multiple of 0.01 (the specific
value used was 0.225x). This meant that due to the rounding applied to
`SliderVelocityMultiplierBindable` via `Precision`, the raw value was
being incorrectly rounded, resulting in incorrect conversion.

The "direct" change that revealed this is most likely
ppy/osu-framework#6249, by the virtue of
shuffling the `BindableNumber` rounding code around and accidentally
changing midpoint rounding semantics in the process. But it was not
at fault here, as rounding was just as wrong before that change
as after in this specific context.
  • Loading branch information
bdach committed May 28, 2024
1 parent 96af0e1 commit a3b8493
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion osu.Game.Rulesets.Catch/Objects/JuiceStream.cs
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ public class JuiceStream : CatchHitObject, IHasPathWithRepeats, IHasSliderVeloci

public BindableNumber<double> SliderVelocityMultiplierBindable { get; } = new BindableDouble(1)
{
Precision = 0.01,
MinValue = 0.1,
MaxValue = 10
};
Expand Down

0 comments on commit a3b8493

Please sign in to comment.