Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify and fix engine range #152

Merged
merged 2 commits into from
Jul 19, 2024
Merged

Conversation

voxpelli
Copy link
Contributor

Adds my installed-check engine range checker and then runs installed-check --ignore-dev to get:

Errors:

argsclopts: Narrower "engines.node" is needed: >=21.0.0
argsclopts: Narrower "engines.npm" is needed: >=10.0.0
cpx2: Narrower "engines.npm" is needed: >=10.0.0

Suggestions:

Combined "engines.node" needs to be narrower: >=21.0.0
Combined "engines.npm" needs to be narrower: >=10.0.0

Then applies that fix (though manually to keep the style instead of by doing npx installed-check --ignore-dev --fix)

I guess this fix is not the desired one though, as I guess top-bun should support at least the latest LTS?

voxpelli added 2 commits July 19, 2024 21:07
- argsclopts: Narrower "engines.node" is needed: >=21.0.0
- argsclopts: Narrower "engines.npm" is needed: >=10.0.0
- cpx2: Narrower "engines.npm" is needed: >=10.0.0
Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] Transitive: environment, filesystem, shell +55 4.38 MB voxpelli
npm/[email protected] Transitive: environment, filesystem, network, shell, unsafe +268 33.3 MB isaacs
npm/[email protected] None 0 21.9 MB typescript-bot
npm/[email protected] None +13 349 kB bret
npm/[email protected] Transitive: filesystem +9 229 kB sindresorhus

🚮 Removed packages: npm/[email protected]

View full report↗︎

@voxpelli
Copy link
Contributor Author

Um, that Socket bot is a bit drunk, only change this PR does is in relation to npm/[email protected], the other five mentions are not touched by this PR, including the "removed" npm/[email protected]

@bcomnes
Copy link
Owner

bcomnes commented Jul 19, 2024

I think its hitting some dependency limit and running analysis with an unbalanced diff or something.

@bcomnes bcomnes merged commit 630f6ae into bcomnes:master Jul 19, 2024
4 checks passed
@voxpelli voxpelli deleted the verify-engine-range branch July 19, 2024 19:55
Copy link

Pull Request Test Coverage Report for Build 10013167398

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.176%

Totals Coverage Status
Change from base Build 9876381842: 0.0%
Covered Lines: 2471
Relevant Lines: 2676

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants