Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/current forward flow fixes optimise #183

Merged
merged 10 commits into from
Jun 9, 2023

Conversation

livingrockrises
Copy link
Contributor

Description

  1. scrap the code for fallback gas tank
  2. avoid calling external api for estimating account deployment
  3. fix handle payment override by only sending non-zero value as baseGas
  4. rely on account computation / call to wallet factory rather than making backend api call to get smart account address
  5. fix smart account state issue. currently sdk has to be reinitialised after doing first transaction that deploys the wallet because state doesn't get updated.
  6. remove hard coded gas limit of 2M

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

// index
// })

console.log(version, index, chainId);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove console.log

Copy link
Contributor Author

@livingrockrises livingrockrises left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed again

@@ -790,19 +661,19 @@ class SmartAccount extends EventEmitter {
}
if (gasLimit) {
relayTrx.gasLimit = gasLimit
} else {
} /*else {
relayTrx.gasLimit = {
hex: '0x16E360',
type: 'hex'
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can remove the commented code too

@livingrockrises livingrockrises merged commit 73a6088 into development Jun 9, 2023
@livingrockrises livingrockrises deleted the fix/current-forward-flow-fixes-optimise branch June 17, 2023 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants