Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add "module" entrypoint, replace esnext with es2020 #105

Merged
merged 1 commit into from
Feb 22, 2020
Merged

add "module" entrypoint, replace esnext with es2020 #105

merged 1 commit into from
Feb 22, 2020

Conversation

FredKSchott
Copy link
Contributor

@FredKSchott FredKSchott commented Feb 13, 2020 •
edited
Loading

Fixes #104

  • Replace "target": "esnext" with "es2020" for more stable modern builds
  • Added more common "module" entrypoint for bundlers to pick up
  • replace most mentions of esnext with esm (this is purely for clarity, happy to rename differently or keep as esnext if you'd prefer)

@FredKSchott FredKSchott requested a review from bcherny February 13, 2020 06:33
@FredKSchott FredKSchott mentioned this pull request Feb 13, 2020
Closed
@bcherny
Copy link
Owner

bcherny commented Feb 22, 2020

Seems reasonable to me. Thanks for the contribution!

@bcherny bcherny merged commit 90fb013 into bcherny:master Feb 22, 2020
@bcherny
Copy link
Owner

bcherny commented Feb 22, 2020

Published 5.2.0.

@FredKSchott FredKSchott deleted the esm-module branch February 25, 2020 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcherny bcherny Awaiting requested review from bcherny

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add ESM 'module' entrypoint
2 participants
@FredKSchott @bcherny