Added a search-depth-limit parameter to limit cycle detection depth #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Limits the depth of cycle reporting to a fixed to a fixied size limit for a list of files. This helps improve performance, as most cycles do not surpass a few related files. As I mentioned in the issue, we could theoretically fix the crashes by switching to an iterative solution. This is still a desirable change IMO because erroring files will do so faster. Fixes #18
|
Thanks for the contribution @JoshuaKGoldberg! Please split this into multiple PRs, one per change you're making. Thanks! |
bcherny
requested changes
Aug 20, 2018
|
will do Edit: split the |
JoshuaKGoldberg
changed the title
|
I don't know why this blocks reopening the PR so I'll just make a new PR. 🤷
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Limits the depth of cycle reporting to a fixed to a fixied size limit for a list of files.
This helps improve performance, as most cycles do not surpass a few related files.
As I mentioned in the issue, we could theoretically fix the crashes by switching to an iterative solution. This is still a desirable change IMO because erroring files will do so faster.
This also switches to a
walkfunction: see discussion in palantir/tslint#2522Fixes #18