Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(facilities): added facilities #413

Merged
merged 10 commits into from
Mar 6, 2025
Merged

Conversation

hamidhabib-buttons
Copy link
Contributor

Description

Added facilities to recreation page

Fixes # (269)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Navigate to a specific resource page
  • Make sure facilities are visible

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments

@hamidhabib-buttons hamidhabib-buttons self-assigned this Mar 4, 2025
@hamidhabib-buttons hamidhabib-buttons marked this pull request as ready for review March 4, 2025 02:45
Copy link
Contributor

@marcellmueller marcellmueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Only thing to mention is do you think that these should be pluralized on the rec resource page? Maybe something to ask Jaimie.

Screenshot 2025-03-05 at 12 46 50 PM

@hamidhabib-buttons hamidhabib-buttons merged commit 1bf6356 into main Mar 6, 2025
32 checks passed
@hamidhabib-buttons hamidhabib-buttons deleted the recreation-facilities branch March 6, 2025 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants