fix/filter counts #406
Merged
fix/filter counts #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcellmueller
force-pushed
the
fix/filter-counts
branch
3 times, most recently
from
ebfc261 to
b94a0f1
Compare
marcellmueller
force-pushed
the
fix/filter-counts
branch
from
b94a0f1 to
501e592
Compare
marcellmueller
force-pushed
the
fix/filter-counts
branch
from
d40746d to
6b86871
Compare
marcellmueller
force-pushed
the
fix/filter-counts
branch
from
6b86871 to
3df2eda
Compare
marcellmueller
force-pushed
the
fix/filter-counts
branch
from
f43cd97 to
bdc772c
Compare
marcellmueller
force-pushed
the
fix/filter-counts
branch
from
bdc772c to
00c86f9
Compare
hamidhabib-buttons
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for some of the new filter counts having different numbers than the results. Some of this was due me forgetting to filter rec resources by things like
display_on_public_site, real world data being different than the dev fixtures as well as some duplicated data inrecreation_accessthat was being imported.I've deployed this to test and ensured the counts line up with the results.