Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fees): added campsite and additional fees #395

Merged
merged 7 commits into from
Feb 26, 2025

Conversation

hamidhabib-buttons
Copy link
Contributor

Description

Implemented campsite fees and additional fees for recreation sites.

Screenshot 2025-02-26 at 9 08 28 AM

Fixes # (206)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Navigate to a specific resource page
  • Navigate to Camping section
  • Make sure fees are visible

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments

@hamidhabib-buttons hamidhabib-buttons self-assigned this Feb 26, 2025
@hamidhabib-buttons hamidhabib-buttons force-pushed the recreation-fees-additional branch from 1b33043 to a7dac08 Compare February 26, 2025 14:25
@hamidhabib-buttons hamidhabib-buttons marked this pull request as ready for review February 26, 2025 14:26
rf.recreation_fee_code
from
fta.recreation_fee rf
left join fta.recreation_fee_code rfc
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: is the join necessary here? doesn't look like we are getting any information from the fee code table ie the description

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just kept the join for future if we want to add more info - but happy to remove it :)

Copy link
Contributor

@marcellmueller marcellmueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates, I think we got the data right this time. Sorry it's all so confusing.

Can we also do a test deployment to confirm that the migrations are working? Let me know if you need help with that, it involves making a test commit to .github/workflows/main.yml and commenting line 44:

if: github.ref_name == 'main' || github.head_ref == 'main'

One minor style nit is there is a different margin between the Number of campsites heading and content compared to the other ones. Can we make this consistent.

Screenshot 2025-02-26 at 10 34 30 AM

@hamidhabib-buttons hamidhabib-buttons merged commit dfff7e8 into main Feb 26, 2025
32 checks passed
@hamidhabib-buttons hamidhabib-buttons deleted the recreation-fees-additional branch February 26, 2025 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants