-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(fees): added campsite and additional fees #395
Conversation
1b33043
to
a7dac08
Compare
rf.recreation_fee_code | ||
from | ||
fta.recreation_fee rf | ||
left join fta.recreation_fee_code rfc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: is the join necessary here? doesn't look like we are getting any information from the fee code table ie the description
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just kept the join for future if we want to add more info - but happy to remove it :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates, I think we got the data right this time. Sorry it's all so confusing.
Can we also do a test deployment to confirm that the migrations are working? Let me know if you need help with that, it involves making a test commit to .github/workflows/main.yml
and commenting line 44:
if: github.ref_name == 'main' || github.head_ref == 'main'
One minor style nit is there is a different margin between the Number of campsites
heading and content compared to the other ones. Can we make this consistent.

Description
Implemented campsite fees and additional fees for recreation sites.
Fixes # (206)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist
Further comments