-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rst-images): modify api and frontend pages to include rst images from DAM #386
Conversation
c8ef8c2
to
be613a5
Compare
The Happo diffs are failing due to:
|
3c60b41
to
dafb954
Compare
@@ -0,0 +1,757 @@ | |||
-- Create the resource_images table if it doesn't exist | |||
CREATE TABLE IF NOT EXISTS rst.recreation_resource_images |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: in the future maybe we can use lowercase for sql commands. Or we can convert the rest of the codebase to use uppercase if that's prefered, though we should pick one.
52963b6
to
5ec1a68
Compare
edcfa67
to
6ece96e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really amazing work on this, this is such a huge lift thanks 🙇
6ece96e
to
a2312d4
Compare
Description
Please provide a summary of the change and the issue fixed. Please include relevant context. List dependency changes.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist
Further comments