Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rst-images): modify api and frontend pages to include rst images from DAM #386

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

jimmypalelil
Copy link
Contributor

Description

Please provide a summary of the change and the issue fixed. Please include relevant context. List dependency changes.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments

@jimmypalelil jimmypalelil force-pushed the feat/rst-images-staging branch 6 times, most recently from c8ef8c2 to be613a5 Compare February 25, 2025 00:54
@jimmypalelil
Copy link
Contributor Author

The Happo diffs are failing due to:

  1. Updated images for recreation sites
  2. Fee description appearing next to fee amount in RecResourcePage

@jimmypalelil jimmypalelil force-pushed the feat/rst-images-staging branch 2 times, most recently from 3c60b41 to dafb954 Compare February 25, 2025 04:05
@marcellmueller
Copy link
Contributor

Hey amazing work, this is working really well.

For your consideration I noticed some image quality issues with the preview images on the rec page:

This one only shows two images, but when I click the carousel there are 5. I think this is just the fixtures, though I think the smaller preview images don't look great when they are displayed in the larger view like this:
Screenshot 2025-02-25 at 8 25 34 AM

This one is a good example where all 4 of the smaller preview images look good but the larger main one on the left looks really pixellated:
Screenshot 2025-02-25 at 8 26 58 AM

@@ -0,0 +1,757 @@
-- Create the resource_images table if it doesn't exist
CREATE TABLE IF NOT EXISTS rst.recreation_resource_images
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: in the future maybe we can use lowercase for sql commands. Or we can convert the rest of the codebase to use uppercase if that's prefered, though we should pick one.

Copy link
Contributor

@marcellmueller marcellmueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really amazing work on this, this is such a huge lift thanks 🙇

@jimmypalelil jimmypalelil force-pushed the feat/rst-images-staging branch from 6ece96e to a2312d4 Compare February 25, 2025 22:50
@jimmypalelil jimmypalelil merged commit b511280 into main Feb 25, 2025
32 checks passed
@jimmypalelil jimmypalelil deleted the feat/rst-images-staging branch February 25, 2025 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants