Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix generics support for constructors #3

Closed
bbottema opened this issue Nov 1, 2019 · 1 comment
Closed

bugfix: fix generics support for constructors #3

bbottema opened this issue Nov 1, 2019 · 1 comment
Labels
bug Something isn't working
Milestone

Comments

@bbottema
Copy link
Owner

bbottema commented Nov 1, 2019

Originally I had added generics support, and it covers most cases, recently I stumbled across a new case that broke the library.

public class ListMyValueClassHoldingClass {
	private List<MyValueClass> myClasses;
	
	public ListMyValueClassHoldingClass(List<MyValueClass> myClasses) {
		this.myClasses = myClasses;
	}
	
	public List<MyValueClass> getMyClasses() {
		return this.myClasses;
	}
}

This case seems to confound lorem-ipsum-objects. The difference seems to be that the parameter in the constructor is not inspected properly whereas a setter method works properly.

@bbottema bbottema added the enhancement New feature or request label Nov 1, 2019
@bbottema bbottema added this to the 2.0.0 milestone Nov 1, 2019
@bbottema bbottema changed the title Support Generics Fix case of broken generics support Nov 2, 2019
@bbottema bbottema added bug Something isn't working and removed enhancement New feature or request labels Nov 2, 2019
@bbottema bbottema closed this as completed Nov 2, 2019
@bbottema bbottema changed the title Fix case of broken generics support bugfix: fix generics support for constructors Nov 2, 2019
@bbottema
Copy link
Owner Author

bbottema commented Nov 2, 2019

Released in 2.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant