feat: adding concurrency functionality #562
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LCOV of commit
|
| private heartbeatInterval: number; | ||
| private isPolling = false; | ||
| private stopRequestedAtTimestamp: number; | ||
| public abortController: AbortController; | ||
| private extendedAWSErrors: boolean; | ||
| private concurrency: number; |
There was a problem hiding this comment.
We may want a maxConcurrency setting that ensures we're not trying to do silly stuff.
| } | ||
| waitingMessages++; | ||
| await new Promise((resolve) => | ||
| setTimeout(resolve, this.concurrencyWaitTimeMs), |
There was a problem hiding this comment.
I need to think if concurrencyWaitTimeMs, it's probably too late and my brain is mush at this point though, but I think this conflicts with the polling timeout? Need to think on it.
lukiano
reviewed
Feb 7, 2025
| try { | ||
| await this.processMessage(message); | ||
| } finally { | ||
| this.inFlightMessages--; |
There was a problem hiding this comment.
It would be nice if it could poll again to maintain maximum concurrency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR looks to add concurrency functionality.
Many users have asked for this in the past, I think this implements it in a decent way that doesn't need any external dependencies and should maintain backwards compatiblity.
There is potential that this might cause breaking issues though, so we should release this as breaking even though it might not be.