Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seeking is in the overview is not working anymore #22

Merged
merged 5 commits into from
Feb 6, 2014

Conversation

thom4parisot
Copy link
Contributor

When I use peaks.js on a local machine, I am not able to seek the audio using the visualizer. I can move the playhead, but once I play press again, it moves back to wherever the audio was playing before (you can test it here). It only works if I seek using the slider from the HTML audio tag.

However, this seems to work fine when I try peaks.js on the official page.

I am running a Chrome 32.0.1700.107 on OS X 10.9.1. Do you know what could be the problem?

Thanks a lot!

@thom4parisot thom4parisot added this to the 0.0.4 — Bugfix milestone Feb 5, 2014
@thom4parisot
Copy link
Contributor

@urinieto yes this is some bug I have introduced in 0.0.2 or 0.0.3. I'm not sure to be able to fix it tomorrow although I target to fix those casualties next week in the worst case scenario. You can still switch back to 0.0.1 meanwhile this issue is still opened.

Thanks for reporting the problem!

@urinieto
Copy link
Author

urinieto commented Feb 5, 2014

Oh, thanks so much for this prompt reply! Well, I'm glad it was not something that I did. I can wait till the fix.

Thanks again, and keep up with this awesome work!

@thom4parisot
Copy link
Contributor

Hello @urinieto: can you checkout the branch fix-seeking (by using this exact value in your bower.json file and running a bower update for example) and confirm me it solved your problem?

Thanks very much :-)

@urinieto
Copy link
Author

urinieto commented Feb 6, 2014

Yes, it works flawlessly. Thank you so much!

…erview.

- added `zoomview_user_seek` event
- syncing playhead animation if the media element is playing
- emitting the `waveform_seek` event on audio element seek instead of emitting it through the API
thom4parisot pushed a commit that referenced this pull request Feb 6, 2014
@thom4parisot thom4parisot merged commit c7eb7b0 into master Feb 6, 2014
@thom4parisot thom4parisot deleted the fix-seeking branch February 6, 2014 18:02
@ghost ghost mentioned this pull request Feb 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants