Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IE9: Unable to get value of the property 'createSegment': object is null or undefined #16

Merged
merged 3 commits into from
Jan 30, 2014
Merged

IE9: Unable to get value of the property 'createSegment': object is null or undefined #16

merged 3 commits into from
Jan 30, 2014

Conversation

thom4parisot
Copy link
Contributor

In the following tests:

  • Peaks API interface should be able to add and return segments
  • player/waveform/waveform.segments addSegment should accept spreaded arguments
  • player/waveform/waveform.segments addSegment should accept an array of Segment objects

Also, Unable to get value of the property 'views': object is null or undefined in:

  • player/waveform/waveform.segments addSegment should paint once, and not after each segment addition

thom4parisot pushed a commit that referenced this pull request Jan 30, 2014
Merge pull request #16 from bbcrd/fix-16
d0d449a 
IE9: Unable to get value of the property 'createSegment': object is null or undefined
@thom4parisot thom4parisot merged commit d0d449a into master Jan 30, 2014
@thom4parisot thom4parisot deleted the fix-16 branch January 30, 2014 16:09
chainlink pushed a commit to chainlink/peaks.js that referenced this pull request May 30, 2014
Merge pull request bbc#16 from JonKoops/master
ccd9f84 
Added normal array & for loop in offsetValues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
0.0.3 - Bugfix
Development

Successfully merging this pull request may close these issues.
1 participant
@thom4parisot