Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Konva.FastLayer for drawing waveforms #144

Merged
merged 1 commit into from
Aug 8, 2016

Conversation

jdelStrother
Copy link
Contributor

FastLayer doesn’t support, eg, hit-testing, which makes it way faster when rendering large waveforms.

FastLayer doesn’t support, eg, hit-testing, which makes it way faster when rendering large waveforms.
@chrisn
Copy link
Member

chrisn commented Aug 8, 2016

Interesting, do you have any advice on how to test the performance improvement?

@jdelStrother
Copy link
Contributor Author

I was mostly manually inspecting it using Chrome's Timeline tab, especially while zooming in & out of hour-long mp3s. Time was split roughly equally between drawScene and drawHit - the latter disappears with FastLayer.

@chrisn
Copy link
Member

chrisn commented Aug 8, 2016

Yes, I see the difference. Nice change, thank you!

@chrisn chrisn merged commit a1dd730 into bbc:master Aug 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants