Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo, seeking instead of seaking #122

Merged
merged 1 commit into from
Jun 30, 2015
Merged

Conversation

ziggythehamster
Copy link
Contributor

You have a typo in waveform.overview.js, this fixes it :)

@thom4parisot
Copy link
Contributor

You mean #102? Or another reported issue?

Thanks in any case :-)

@ziggythehamster
Copy link
Contributor Author

I have no idea what this affects, or even if it's been reported, but you obviously meant seeking :). This fix makes it so that the state is more consistent - otherwise, if you go crazy, you end up with maybe the playhead thinking it's at one position and then going past the end or beginning of the file, but it's actually at a different position.

@thom4parisot
Copy link
Contributor

Agreed, it is definitely seeking. I would have linked and closed the related issue otherwise!

Thanks a lot, definitely helpful :-)

thom4parisot pushed a commit that referenced this pull request Jun 30, 2015
Fix typo, seeking instead of seaking
@thom4parisot thom4parisot merged commit 5ce935a into bbc:master Jun 30, 2015
@ziggythehamster ziggythehamster deleted the seeking-typo branch July 2, 2015 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants