Make the axis label and gridline colors configurable #113
Conversation
… in another build pipeline.
ziggythehamster
changed the title
| @@ -37,6 +37,7 @@ | |||
| "license": "LGPL 3", | |||
| "scripts": { | |||
| "build": "browserify -d ./src/main.js -p [minifyify --map peaks.min.map --output peaks.min.map] -s peaks -o peaks.min.js", | |||
| "build-max": "browserify ./src/main.js -s peaks -o peaks.js", | |||
There was a problem hiding this comment.
What is build-max done for?
There was a problem hiding this comment.
I take the outputted peaks.js file and drop it into a Broccoli pipeline which minifies it and inlines it with my other JavaScript. It does not work very well when it tries to minify the already minified version.
There was a problem hiding this comment.
Also, I didn't intend for that commit to make it to this PR, but it doesn't hurt anything for it to be there ;)
There was a problem hiding this comment.
It does not, but it does not help to carry over more and more things without a need.
I agree though building a non-minified artefact can be useful :-)
|
Thanks a lot. If I understand well, |
|
Correct - |
|
👍 |
Make the axis label and gridline colors configurable
This also fixes a regression from the KineticJS upgrade, which broke painting the axis in anything other than black. Using
setAttron the context makes it work as expected and now the axis is painted in the correct color.