Change fill-column-indicator face

[tsuu32]

Emacs 27 has fill-column-indicator face and M-x display-fill-column-indicator-mode.

Current zenburn-emacs's fill-column-indicator is hard to see.
I changed fill-column-indicator face.

Before:

After:

cc @tarsius (because of efe7293)

---

Before submitting a PR make sure the following things have been done (and denote this
by checking the relevant checkboxes):

• The commits are consistent with our contribution guidelines
• You've updated the changelog (if adding/changing user-visible functionality)
• You've updated the readme (if adding/changing user-visible functionality)

Thanks!

[tarsius]

That's intentional. If that line is visible more then it is also more of a distraction. IMO this should not be merged and those users who want to see this line very well should theme it locally.

[tsuu32]

But I think current is too dark to use. fill-column-indicator exists to indicate. So visibility is important for practicality.

[tarsius]

There are many things that could theoretically be visualized at all times. If these indicators were all enabled at the same time, then that would lead to information overload.

I think that displaying the indicator the way it is currently being displayed is a good compromise. When one actually goes over the limit or if one intentionally focuses ones attention on that line, then one can see it well. At all other times the line nicely blends into the background and does not compete with other more pressing information for the users attention, which is nice because then this information is not actually relevant.

Of course you may care more about this limit than I do and want the line to be very visible at all times. We just have two different personal preferences, which is perfectly fine but it means that one of use has to customize this color.

The maintainer of this theme might have the same preference as you or me or not care one bit. Unless he strongly prefers your way I suggest he does not change this. The old color was in use for quite some time without anyone else suggesting that it be changed. That might mean that the majority prefers the status quo. Or maybe many users prefer it your way and they just customized this in their personal configuration (in which case they would not benefit from the default changing).

Unless users keep on asking for this color to be changed, it seems like the safest option to not change it. Someone has to customized this and unfortunately for you that currently is you.

[tsuu32]

Thanks for the response.

There are many things that could theoretically be visualized at all times. If these indicators were all enabled at the same time, then that would lead to information overload.

It seems that you and I are in different use cases. I don't enable display-fill-column-indicator-mode at all times, but I enable display-fill-column-indicator-mode only when I want to see display-fill-column-indicator. So I don't feel noisy.

I think that displaying the indicator the way it is currently being displayed is a good compromise. When one actually goes over the limit or if one intentionally focuses ones attention on that line, then one can see it well. At all other times the line nicely blends into the background and does not compete with other more pressing information for the users attention, which is nice because then this information is not actually relevant.

Hmm... I understood your preference, but Emacs 27 fill-column-indicator face default is the one that inherit shadow face, which is clear gray against white background. I don't think fill-column-indicator should be very clear in every themes but I think current zenburn's fill-column-indicator is a little unclear.

The maintainer of this theme might have the same preference as you or me or not care one bit. Unless he strongly prefers your way I suggest he does not change this. The old color was in use for quite some time without anyone else suggesting that it be changed. That might mean that the majority prefers the status quo. Or maybe many users prefer it your way and they just customized this in their personal configuration (in which case they would not benefit from the default changing).

I think some people will say the same thing in the future when Emacs 27 will be released.

ok. I'll wait the maintainer(@bbatsov)'s decision. I'll follow it.

[aycanirican]

@tsuu32 Thank you for your PR. I think existing face is unusable since first time I have added fill-column-indicator to my configuration i couldn't see the boundary and thought that I made a mistake in my config but turns out that the boundary already there but almost invisible.

I think more experienced emacs users can darken it by customizing the face but for the default case I think it should be easy to spot.

[hellwolf]

aha, indeed, it's just not easily visible. What was your workaround folks?

[hellwolf]

I like it, please!