Add specific push opcodes for different data types #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add dependencies to go.mod
The convention in Go is to use MixedCaps or mixedCaps rather than underscores to write multiword names. Ref: https://stackoverflow.com/questions/22688906/go-naming-conventions-for-const
PushBool pushes a boolean value (0 or 1) onto evaluation stack
PushChar puts a byte(0-127) onto stack
Support pushing strings (as ascii char codes) onto stack
Push opcode pushes any number of byte sequence onto the stack
PushInt represents big integer values
PushInt uses only 1 byte zero, because it does not require sign byte
skas102
approved these changes
Apr 8, 2019
skas102
approved these changes
Apr 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support
fixes Issue #5