Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move transitive dependency mode tests to use ast dependency method #1041

Closed
wants to merge 1 commit into from

Conversation

Jamie5
Copy link
Contributor

@Jamie5 Jamie5 commented Apr 30, 2020

Description

We change the transitive dependency mode tests to use the ast dependency method.

This allows us to use an instance of unused_dependency_checker_ignored_targets which was needed to a deficiency in the high-level analyzer.

Motivation

As we are moving towards using the ast dependency method for transitive dependency mode, we wish to make the tests align with that. We also wish to not use unused_dependency_checker_ignored_targets when not necessary.

@Jamie5 Jamie5 requested a review from ittaiz as a code owner April 30, 2020 22:25
@Jamie5
Copy link
Contributor Author

Jamie5 commented Apr 30, 2020

@ittaiz this happens to address #1034 .

Is it too early to stop running high-level transitive? If so I guess we'd have to leave this for a later point.

@ittaiz
Copy link
Member

ittaiz commented May 1, 2020

I feel it's too soon yeah.
Maybe we should have these tests run both modes for now? Won't help with the unused_dependency_checker_ignored_targets but will give more inputs

@Jamie5
Copy link
Contributor Author

Jamie5 commented May 2, 2020

Hmm seems that would add more time to test running (not sure how much). So far not seeing any issues which would need to push removing the dependency_tracking_method past July 30 so seems probably fine to wait until nearer to then.

@liucijus liucijus added the dep-tracking Strict/unused deps, label collections related issues label Mar 22, 2021
@liucijus
Copy link
Collaborator

closing as stale, feel free to reopen

@liucijus liucijus closed this Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes dep-tracking Strict/unused deps, label collections related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants